guozhangwang commented on a change in pull request #9170:
URL: https://github.com/apache/kafka/pull/9170#discussion_r469517595
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -193,13 +193,17 @@ private void closeAndRevive(final Map<Task,
Collection<TopicPartition>> taskWith
try {
task.suspend();
+ // we need to enforce a checkpoint that removes the corrupted
partitions
+ task.postCommit(true);
Review comment:
Here since the task is guaranteed to be in SUSPENDED `postCommit()` is
ensured to trigger checkpointing.
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##########
@@ -1609,12 +1609,11 @@ public void shouldReturnStateManagerChangelogOffsets() {
}
@Test
- public void shouldCheckpointWithCreatedStateOnClose() {
+ public void shouldNotCheckpointOnCloseCreated() {
Review comment:
It was the same as the other one, that it was wrong to begin with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
