ableegoldman commented on a change in pull request #8834:
URL: https://github.com/apache/kafka/pull/8834#discussion_r469593402
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -1069,6 +1069,13 @@ private HeartbeatResponseHandler(final Generation
generation) {
public void handle(HeartbeatResponse heartbeatResponse,
RequestFuture<Void> future) {
sensors.heartbeatSensor.record(response.requestLatencyMs());
Errors error = heartbeatResponse.error();
+
+ if (state != MemberState.STABLE) {
Review comment:
I agree with @vvcephei , we should aim to keep this fix as simple as
possible. The reason for this PR is that members are getting kicked from the
group unnecessarily, not that members who are actually supposed to be fenced
don't rejoin fast enough.
If we fix KAFKA-10122 and people start complaining that members fenced
during a rebalance take too long to find out, then we can revisit this
optimization. But if KAFKA-10122 is fixed then it seems like the occurrence of
members dropping out during a rebalance will go way down anyway, so we'd be
solving a vanishingly small problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
