ivandasch commented on a change in pull request #9196:
URL: https://github.com/apache/kafka/pull/9196#discussion_r475086583
##########
File path: tests/kafkatest/services/monitor/http.py
##########
@@ -154,7 +154,7 @@ def do_POST(self):
name = raw_metric['name']
group = raw_metric['group']
# Convert to tuple of pairs because dicts & lists are unhashable
- tags = tuple([(k, v) for k, v in raw_metric['tags'].iteritems()]),
+ tags = tuple([(k, v) for k, v in
iter(raw_metric['tags'].items())]),
Review comment:
Same as above + tuple can be constructed from generator, no need to
create list for that
Just use `tuple(raw_metric['tags'].items())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
