cmccabe commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r475714230
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/AlterConfigsRequest.java
##########
@@ -87,6 +87,16 @@ public Builder(Map<ConfigResource, Config> configs, boolean
validateOnly) {
public AlterConfigsRequest build(short version) {
return new AlterConfigsRequest(data, version);
}
+
Review comment:
In general we don't define equals or hashCode on these builders. Why
are we defining it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
