bbejeck commented on pull request #9099:
URL: https://github.com/apache/kafka/pull/9099#issuecomment-679258872


   > I should just delete the test for DefaultMessageFormatter in 
ConsoleConsumerTest.scala.
   
   @badaiaqrandista
   
   I'm not sure.  My vote would be to keep the test but move it over to the 
`DefaultMessageFormatterTest.scala` class.  
   
   But I'm not familiar enough with this code to say for sure.  From a quick 
look at the old test, it's not clear to me why it failed.  I guess the 
`Partition number` gets printed by default now?
   
   \cc @dajac 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to