ijuma commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479829275
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -68,6 +68,13 @@ object LogAppendInfo {
offsetsMonotonic = false, -1L, recordErrors, errorMessage)
}
+sealed trait LeaderHWChange
+object LeaderHWChange {
+ case object Incremental extends LeaderHWChange
Review comment:
Another nit: `LeaderHwChange` adheres to the coding convention better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
