[GitHub] [kafka] showuon commented on a change in pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

[GitBox]

showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486749618



##########
File path: 
core/src/main/scala/kafka/server/checkpoints/LeaderEpochCheckpointFile.scala
##########
@@ -52,8 +52,16 @@ object LeaderEpochCheckpointFile {
 }
 
 /**
-  * This class persists a map of (LeaderEpoch => Offsets) to a file (for a 
certain replica)
-  */
+ * This class persists a map of (LeaderEpoch => Offsets) to a file (for a 
certain replica)
+ *
+ * The format in the LeaderEpoch checkpoint file is like this:
+ * -----checkpoint file begin------
+ * 0                <- LeaderEpochCheckpointFile.currentVersion
+ * 2                <- following entries size
+ * 0  1     <- the format is: leader_epoch(int32) end_offset(int64)

Review comment:
       You are right. I referenced the KIP-101 to document it. After your 
reminding, I found the KIP is wrong. In the description, it said it's "Start 
offset", but in the table below, it becomes "end offset". I confirmed this is 
typo. I also updated the KIP as well. Thank you.
   
   
   
![image](https://user-images.githubusercontent.com/43372967/92851603-5aef8980-f420-11ea-9704-a54e297c6cc2.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org