[GitHub] [kafka] vvcephei commented on a change in pull request #9239: Adding reverse iterator usage for sliding windows processing (extending KIP-450)

[GitBox]

vvcephei commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r487171555



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
     public void testReduceSmallInput() {
         final StreamsBuilder builder = new StreamsBuilder();
         final String topic = "topic";
+        final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new 
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) : 
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000), 
Duration.ofMillis(10), false);

Review comment:
       But I wouldn't be afraid to just use a full if/else block, either.
   
   ```suggestion
           final WindowBytesStoreSupplier storeSupplier;
           if (inOrderIterator) {
               storeSupplier = new InOrderMemoryWindowStoreSupplier("InOrder", 
50000L, 10L, false);
           } else {
               storeSupplier = Stores.inMemoryWindowStore("Reverse", 
ofMillis(50000), ofMillis(10), false);
           }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org