[GitHub] [kafka] chia7712 commented on pull request #9250: KAFKA-10461 The config of closing heartbeat is invalid.

[GitBox]

chia7712 commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691601314


   
https://github.com/apache/kafka/blob/trunk/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java#L64
   
   ```
       @Override
       public List<Map<String, String>> taskConfigs(int maxTasks) {
           // if the heartbeats emission is disabled by setting 
`emit.heartbeats.enabled` to `false`,
           // the interval heartbeat emission will be negative and no 
`MirrorHeartbeatTask` will be created
           if (config.emitHeartbeatsInterval().isNegative()) {
               return Collections.emptyList();
           }
           // just need a single task
           return Collections.singletonList(config.originalsStrings());
       }
   ```
   
   It seems that no task will be created if ```emit.heartbeats.enabled``` is 
set to false. Do you observe something weird? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org