hachikuji commented on a change in pull request #9275:
URL: https://github.com/apache/kafka/pull/9275#discussion_r488262695
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##########
@@ -232,19 +263,25 @@ public FetchRequest build(short version) {
// We collect the partitions in a single FetchTopic only if they
appear sequentially in the fetchData
FetchRequestData.FetchTopic fetchTopic = null;
for (Map.Entry<TopicPartition, PartitionData> entry :
fetchData.entrySet()) {
- if (fetchTopic == null ||
!entry.getKey().topic().equals(fetchTopic.topic())) {
+ TopicPartition topicPartition = entry.getKey();
+ PartitionData partitionData = entry.getValue();
+
+ if (fetchTopic == null ||
!topicPartition.topic().equals(fetchTopic.topic())) {
fetchTopic = new FetchRequestData.FetchTopic()
- .setTopic(entry.getKey().topic())
+ .setTopic(topicPartition.topic())
.setPartitions(new ArrayList<>());
fetchRequestData.topics().add(fetchTopic);
}
- fetchTopic.partitions().add(
- new
FetchRequestData.FetchPartition().setPartition(entry.getKey().partition())
-
.setCurrentLeaderEpoch(entry.getValue().currentLeaderEpoch.orElse(RecordBatch.NO_PARTITION_LEADER_EPOCH))
- .setFetchOffset(entry.getValue().fetchOffset)
- .setLogStartOffset(entry.getValue().logStartOffset)
- .setPartitionMaxBytes(entry.getValue().maxBytes));
+ FetchRequestData.FetchPartition fetchPartition = new
FetchRequestData.FetchPartition()
+ .setPartition(topicPartition.partition())
+
.setCurrentLeaderEpoch(partitionData.currentLeaderEpoch.orElse(RecordBatch.NO_PARTITION_LEADER_EPOCH))
+ .setFetchOffset(partitionData.fetchOffset)
+ .setLogStartOffset(partitionData.logStartOffset)
+ .setPartitionMaxBytes(partitionData.maxBytes);
+
partitionData.lastFetchedEpoch.ifPresent(fetchPartition::setLastFetchedEpoch);
Review comment:
I guess I was trying to rely on the default from the schema, but I agree
probably no reason to be inconsistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
