big-andy-coates commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-694203001
@mjsax - ready for another review. - boolean `onlyIfMaterialized` is now flipped to `forceMaterialization`. - `KTableFilter` constructor initialized internal `sendOldValues` flag based on parent tables state. (Not perfect, but works). - Removed test that was testing bad behaviour. The only outstanding piece, as I see it, is the bad behaviour if you call `enableSendingOldValues` without forcing materialization on a table that is itself materialized, but who's upstream is not. In such a situation, the table will _not_ enable sending old values. A similar bug existed before this PR: if you called `enableSendingOldValues` on a table that is itself materialized, but who's upstream is not, then it will force materialization on its upstream table, which is unnecessary. With the new code, both of the bad behaviours are true, i.e. the change introduces the first one and the second one is still happening. I've raised https://issues.apache.org/jira/browse/KAFKA-10494 to track this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
