vvcephei commented on a change in pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#discussion_r492302522
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##########
@@ -288,17 +288,17 @@ public void computeTaskLags(final UUID uuid, final
Map<TaskId, Long> allTaskEndO
final Long endOffsetSum = taskEntry.getValue();
final Long offsetSum = taskOffsetSums.getOrDefault(task, 0L);
- if (endOffsetSum < offsetSum) {
+ if (offsetSum == Task.LATEST_OFFSET) {
+ taskLagTotals.put(task, Task.LATEST_OFFSET);
+ } else if (offsetSum == UNKNOWN_OFFSET_SUM) {
+ taskLagTotals.put(task, UNKNOWN_OFFSET_SUM);
+ } else if (endOffsetSum < offsetSum) {
Review comment:
Huh, I thought we fixed this a while ago. Why it it showing up in the
diff right now?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java
##########
@@ -77,13 +86,8 @@
public static final TaskId TASK_2_3 = new TaskId(2, 3);
public static final Set<TaskId> EMPTY_TASKS = emptySet();
- public static final List<TaskId> EMPTY_TASK_LIST = emptyList();
- public static final Map<TaskId, Long> EMPTY_TASK_OFFSET_SUMS = emptyMap();
public static final Map<TopicPartition, Long> EMPTY_CHANGELOG_END_OFFSETS
= new HashMap<>();
- private AssignmentTestUtils() {}
Review comment:
Why remove this? Do we need to instantiate this class now? (I only see
static members still).
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java
##########
@@ -77,13 +86,8 @@
public static final TaskId TASK_2_3 = new TaskId(2, 3);
public static final Set<TaskId> EMPTY_TASKS = emptySet();
- public static final List<TaskId> EMPTY_TASK_LIST = emptyList();
- public static final Map<TaskId, Long> EMPTY_TASK_OFFSET_SUMS = emptyMap();
public static final Map<TopicPartition, Long> EMPTY_CHANGELOG_END_OFFSETS
= new HashMap<>();
- private AssignmentTestUtils() {}
Review comment:
Ah, note the `private`. The purpose of this constructor is to make it
uninstantiable. I.e., it's "self-documenting" that it should only be a
container for static members.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
