abbccdda commented on a change in pull request #9083:
URL: https://github.com/apache/kafka/pull/9083#discussion_r492941448
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##########
@@ -1566,6 +1566,7 @@ public void shouldCheckpointForSuspendedTask() {
EasyMock.verify(stateManager);
}
+
Review comment:
nit: not necessary
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java
##########
@@ -217,12 +217,12 @@ public StateStore getStateStore(final String name) {
forward((ProcessorNode<K, V, ?, ?>) child, key, value);
}
} else {
- final ProcessorNode<K, V, ?, ?> child =
currentNode().getChild(sendTo);
Review comment:
+1
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamFlatTransformValues.java
##########
@@ -44,19 +45,18 @@ public KStreamFlatTransformValues(final
ValueTransformerWithKeySupplier<KIn, VIn
return valueTransformerSupplier.stores();
}
- public static class KStreamFlatTransformValuesProcessor<KIn, VIn, VOut>
implements Processor<KIn, VIn> {
+ public static class KStreamFlatTransformValuesProcessor<KIn, VIn, VOut>
extends AbstractProcessor<KIn, VIn> {
Review comment:
Could you elaborate why this is better than Processor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
