guozhangwang commented on a change in pull request #9083:
URL: https://github.com/apache/kafka/pull/9083#discussion_r492944504
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java
##########
@@ -217,12 +217,12 @@ public StateStore getStateStore(final String name) {
forward((ProcessorNode<K, V, ?, ?>) child, key, value);
}
} else {
- final ProcessorNode<K, V, ?, ?> child =
currentNode().getChild(sendTo);
Review comment:
I made the change in ProcessorNode to add back the template types:
https://github.com/apache/kafka/pull/9083/files/82b6f6f5d238401097e0906c8135c5c189524666#diff-705bfd0ed3f214048b76d775708cc7d2L96
But since `currentNode()`'s template is `<?, ?, ?, ?>` its templated
`getChild` and that's why I need to weaken it here --- as you can see from the
above `if` branch, it now aligns consistently on the typing.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamFlatTransformValues.java
##########
@@ -44,19 +45,18 @@ public KStreamFlatTransformValues(final
ValueTransformerWithKeySupplier<KIn, VIn
return valueTransformerSupplier.stores();
}
- public static class KStreamFlatTransformValuesProcessor<KIn, VIn, VOut>
implements Processor<KIn, VIn> {
+ public static class KStreamFlatTransformValuesProcessor<KIn, VIn, VOut>
extends AbstractProcessor<KIn, VIn> {
Review comment:
As described in at the top, `Let all built-in processors to extend from
AbstractProcessor.` The main reason is that AbstractProcessor provides some
basic functionalities and hence it's better to let our own impl to base on them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
