tombentley commented on a change in pull request #9266:
URL: https://github.com/apache/kafka/pull/9266#discussion_r496048334
##########
File path:
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
##########
@@ -2061,11 +2062,12 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
@Test
def testDescribeConfigsForLog4jLogLevels(): Unit = {
client = Admin.create(createConfig)
-
+ LoggerFactory.getLogger("kafka.cluster.Replica").trace("Message to create
the logger")
val loggerConfig = describeBrokerLoggers()
- val rootLogLevel = loggerConfig.get(Log4jController.ROOT_LOGGER).value()
+ val kafkaLogLevel = loggerConfig.get("kafka").value()
val logCleanerLogLevelConfig = loggerConfig.get("kafka.cluster.Replica")
- assertEquals(rootLogLevel, logCleanerLogLevelConfig.value()) // we expect
an undefined log level to be the same as the root logger
+ // we expect an undefined log level to be the same as its first ancestor
logger
Review comment:
It would, but that's not configured in the `log4j.properties` used for
this test, so we inherit from the 2nd ancestor, which is ERROR, where as the
root logger was OFF. Which is why I had to fix this test. Let me fix the
comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
