chia7712 commented on a change in pull request #9347:
URL: https://github.com/apache/kafka/pull/9347#discussion_r497229208
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java
##########
@@ -133,11 +133,14 @@ public void start() {
List<TopicPartition> partitions = new ArrayList<>();
// We expect that the topics will have been created either manually by
the user or automatically by the herder
- List<PartitionInfo> partitionInfos = null;
- long started = time.milliseconds();
- while (partitionInfos == null && time.milliseconds() - started <
CREATE_TOPIC_TIMEOUT_MS) {
+ List<PartitionInfo> partitionInfos = consumer.partitionsFor(topic);
+ long started = time.nanoseconds();
+ long maxSleepMs = 1_000;
+ long sleepMs = 10;
+ while (partitionInfos == null && time.nanoseconds() - started <
CREATE_TOPIC_TIMEOUT_NS) {
+ time.sleep(sleepMs);
+ sleepMs = Math.min(2 * sleepMs, maxSleepMs);
partitionInfos = consumer.partitionsFor(topic);
Review comment:
@soondenana Thanks for responses. This patch LGTM. What I want to
discuss is unrelated to this patch.
> they do it if they get an invalid result back. If null was a valid result
for them, they shouldn't retry either.
If the topic is not exist (or not been propagated yet), ```partitionFor```
can return null. By contrast, ```beginningOffsets``` (and other methods) throws
```TimeoutException```. In order to make consistent behavior,
```beginningOffsets``` (and other methods) should let the topic (or partition)
be absent in the returned ```Map```. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
