rajinisivaram commented on a change in pull request #9356: URL: https://github.com/apache/kafka/pull/9356#discussion_r497644530
########## File path: clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java ########## @@ -214,7 +214,11 @@ SaslClient createSaslClient() { String[] mechs = {mechanism}; log.debug("Creating SaslClient: client={};service={};serviceHostname={};mechs={}", clientPrincipalName, servicePrincipal, host, Arrays.toString(mechs)); - return Sasl.createSaslClient(mechs, clientPrincipalName, servicePrincipal, host, configs, callbackHandler); + SaslClient retvalSaslClient = Sasl.createSaslClient(mechs, clientPrincipalName, servicePrincipal, host, configs, callbackHandler); Review comment: Should we fix server creation as well? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org