mjsax commented on a change in pull request #8130:
URL: https://github.com/apache/kafka/pull/8130#discussion_r497720320
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2419,7 +2419,7 @@ class Log(@volatile private var _dir: File,
// replace old segment with new ones
info(s"Replacing overflowed segment $segment with split segments
$newSegments")
- replaceSegments(newSegments.toList, List(segment), isRecoveredSwapFile =
false)
+ replaceSegments(newSegments.toList, List(segment))
Review comment:
@guozhangwang Is this ok? I am not familiar with this part of the code.
If `false` the default anyway?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
