kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r498113308



##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -219,6 +226,8 @@ class KafkaController(val config: KafkaConfig,
    * This ensures another controller election will be triggered and there will 
always be an actively serving controller
    */
   private def onControllerFailover(): Unit = {
+    maybeSetupFeatureVersioning()

Review comment:
       Done. Good point. It looks appropriate to me that we exit the broker in 
this case. I've captured the exception and added a call to `Exit.exit(1)`, is 
there a better way to do it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to