asdaraujo commented on a change in pull request #9281:
URL: https://github.com/apache/kafka/pull/9281#discussion_r498402453
##########
File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala
##########
@@ -218,16 +220,26 @@ class KafkaConfigTest {
props.put(KafkaConfig.ZkConnectProp, "localhost:2181")
// listeners with duplicate port
- props.put(KafkaConfig.ListenersProp,
"PLAINTEXT://localhost:9091,TRACE://localhost:9091")
- assertFalse(isValidKafkaConfig(props))
+ props.put(KafkaConfig.ListenersProp,
"PLAINTEXT://localhost:9091,SSL://localhost:9091")
+ var caught = intercept[IllegalArgumentException] {
KafkaConfig.fromProps(props) }
+ assertThat(caught.getMessage(), containsString("Each listener must have a
different port"))
Review comment:
Nice. I'll change that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
