pgwhalen commented on a change in pull request #9361:
URL: https://github.com/apache/kafka/pull/9361#discussion_r498610219



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java
##########
@@ -55,6 +52,16 @@
      */
     TaskId taskId();
 
+    /**
+     * The metadata of the record, if it is defined. Note that as long as the 
processor is

Review comment:
       (I'll offer an opinion here because I stressed the importance of it on 
the mailing list, though I do think this is already pretty good.  Feel free to 
take it or leave it, it's just a rewording that may or may not add clarity)
   
   > Note that as long as the processor is receiving a record downstream of a 
Source
   
   Isn't every record received downstream of a source one way or another?  IMO 
the up front emphasis should be on _how_ the record came from the upstream 
processor.  My attempt:
   
   > The record metadata is defined if the record currently being processed was 
passed through parent processor(s) directly from a Source.  It is undefined if 
the record was forwarded from within a Punctuator.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to