rondagostino commented on pull request #9370: URL: https://github.com/apache/kafka/pull/9370#issuecomment-703313051
@Fleshgrinder Thanks for the PR. I'll let others comment on the main gist of it (`null` has probably wasted more than a billion dollars, so I'm generally all for mitigating the damage to the extent possible). Regarding the bug you found, I believe that since KIP-554 stated the behavior publicly the behavior has to stay that way unless there is another KIP to change it. One approach is to add a test that exposes the issue and commit that test and the corresponding fix. The issue can be exposed by eliminating the `usersRequestedList` parameter at https://github.com/apache/kafka/blob/trunk/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java#L4528. I would be glad to open a PR if that is ultimately how we decide we want to go, or feel free to do what you want/need here based on the discussion -- either way is fine with me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
