piotrrzysko commented on pull request #9371: URL: https://github.com/apache/kafka/pull/9371#issuecomment-704430920
Thanks for the review, @stanislavkozlovski. If I understand your point clearly, you are wondering whether this validation will block changing the replication factor for all partitions (replication factor of a topic). Right? It will not if all requested reassignments in the batch have the same number of target replicas for a given topic. Please take look at the test `ReassignPartitionsIntegrationTest::testReassignmentFailOnInconsistentReplicationFactorBetweenPartitions` - topic `bar`. It is a simple case because the topic has only one partition, but it shows that changing the replication factor from 3 to 4 is possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
