mjsax commented on a change in pull request #9384:
URL: https://github.com/apache/kafka/pull/9384#discussion_r500574645



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/HighAvailabilityStreamsPartitionAssignorTest.java
##########
@@ -131,12 +130,13 @@
 
     // Make sure to complete setting up any mocks (such as TaskManager or 
AdminClient) before configuring the assignor
     private void configurePartitionAssignorWith(final Map<String, Object> 
props) {
+        EasyMock.replay(taskManager, adminClient);
+
         final Map<String, Object> configMap = configProps();
         configMap.putAll(props);
 
         streamsConfig = new StreamsConfig(configMap);
         partitionAssignor.configure(configMap);
-        EasyMock.replay(taskManager, adminClient);

Review comment:
       We need to setup the mocks before calling 
`partitionAssignor.configure()` now, as we call `taskManager#adminClient()` in 
this method (similar elsewhere)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to