ableegoldman commented on a change in pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#discussion_r501346943
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java
##########
@@ -359,7 +431,11 @@ private void getNextSegmentIterator() {
setCacheKeyRange(currentSegmentBeginTime(),
currentSegmentLastTime());
current.close();
- current = context.cache().range(cacheName, cacheKeyFrom,
cacheKeyTo);
+ if (forward) {
Review comment:
Ohh yeah good catch. Kind of weird that we're inconsistent with which
underlying store type is used in the existing caching store tests, too. But
thanks for adding the in-memory + persistent flavors for the SessionStore, I
think it sounds reasonable to file a ticket to follow up on the Window/KV
flavors and clean up the caching tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
