ableegoldman commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501394335
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -98,6 +98,10 @@ public StateDirectory(final StreamsConfig config, final Time
time, final boolean
throw new ProcessorStateException(
String.format("state directory [%s] doesn't exist and couldn't
be created", stateDir.getPath()));
}
+ if (stateDirName.startsWith("/tmp")) {
Review comment:
Actually maybe we should wrap it in an `if hasPersistentStores` so that
users won't get this warning if they don't actually have any persistent state
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -98,6 +98,10 @@ public StateDirectory(final StreamsConfig config, final Time
time, final boolean
throw new ProcessorStateException(
String.format("state directory [%s] doesn't exist and couldn't
be created", stateDir.getPath()));
}
+ if (stateDirName.startsWith("/tmp")) {
Review comment:
Actually maybe we should wrap it in an `if hasPersistentStores` so that
users won't get this warning if they don't have any persistent state
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
