vvcephei commented on pull request #9139: URL: https://github.com/apache/kafka/pull/9139#issuecomment-705311946
Ok, I've pushed a couple of commits addressing my feedback. I absolutely share the desire to clean up bad formatting in the codebase, but when PRs are this extensive, I'd suggest eliminating absolutely all changes that aren't directly related to the change. The extra whitespace changes, etc., just add noise that makes it harder for reviewers to do their job. Plus, it increases the probability of merge conflicts. I'd encourage sending a separate PR applying formatting changes or other style fixes. This is what I do myself. Anyway, I rolled back the "extra" stuff. I also applied a couple of extra formatting changes to make the new code itself comply with the style guidelines. And it looks like Jenkins finally woke up, so I'll let it go ahead and finish running. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
