dajac commented on a change in pull request #9391:
URL: https://github.com/apache/kafka/pull/9391#discussion_r501505455
##########
File path:
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchResponseTest.java
##########
@@ -159,14 +159,14 @@ public void testShouldThrottle() {
@Test
public void testNullableMetadata() {
+ PartitionData pd = new PartitionData(
+ offset,
+ leaderEpochOne,
+ null,
+ Errors.UNKNOWN_TOPIC_OR_PARTITION);
+ assertEquals(pd, pd);
Review comment:
I believe that one could be easily tempted to remove such assertion
without knowing the context. I would add a comment to explain it or define a
dedicate test case for the bug. I am fine with either ways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
