apovzner commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r502091323
##########
File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala
##########
@@ -409,6 +409,67 @@ class ConnectionQuotasTest {
verifyConnectionCountOnEveryListener(connectionQuotas,
connectionsPerListener)
}
+ @Test
Review comment:
It would be useful to add a test where we have both per-listener and per
IP limit, and verify that it throttles based on which limit is reached first.
Something like: 2 IPs, each per IP limit < per-listener limit, but sum of per
IP limits > listener limit. So, if you reach limit on one IP, the broker would
not throttle the second IP until it reaches per listener limit. Does not have
to be exactly this, just need to verify how per IP throttling interacts with
per listener throttling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
