[GitHub] [kafka] hachikuji commented on a change in pull request #9352: KAFKA-10533; KafkaRaftClient should flush log after appends

[GitBox]

hachikuji commented on a change in pull request #9352:
URL: https://github.com/apache/kafka/pull/9352#discussion_r503605087



##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -985,6 +986,8 @@ private boolean handleFetchResponse(
                 Records records = (Records) partitionResponse.recordSet();
                 if (records.sizeInBytes() > 0) {
                     LogAppendInfo info = log.appendAsFollower(records);
+                    log.flush();

Review comment:
       I considered this, but it's a little more awkward since the high 
watermark is coming from the request. However, I pushed an update which factors 
out an `appendAsFollower` call which is nearly symmetric with the existing 
`appendAsLeader`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org