efeg commented on pull request #9397:
URL: https://github.com/apache/kafka/pull/9397#issuecomment-708055229
@tombentley thanks for the feedback!
> @efeg the javadoc for `KafkaAdminClient` says "Users should not refer to
this class directly", so just adding the thread-safety note to
`KafkaAdminClient` probably isn't so helpful, we should add it to `Admin` too.
Though since that's an interface probably some wording like "The instances
returned from the {@code create} methods are guaranteed to be thread safe"
would be better.
Makes sense -- updated the JavaDoc of `Admin`.
> This is also an opportunity to improve the rather scant Javadoc for
`Admin`. Compare it to the extensive Javadoc for `KafkaProducer` and
`KafkaConsumer`.
I agree that `Admin` JavaDoc would benefit from a proper revision to make it
on par with the other client docs. That being said, to avoid scope creep, I
would prefer to keep this PR about the thread-safety of Admin clients.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
