kkonstantine commented on a change in pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#discussion_r505137462
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -409,6 +409,9 @@ private boolean sendRecords() {
// RegexRouter) topic creation can not be batched for multiple topics
private void maybeCreateTopic(String topic) {
if (!topicCreation.isTopicCreationRequired(topic)) {
+ log.trace("The topic creation setting is disabled or the topic
name {} is already in the topic cache." +
+ "If the topic doesn't exist, we'll rely on the
auto.create.topics.enable setting in broker side " +
+ "to see if the topic can be auto created or not", topic);
Review comment:
```suggestion
"If auto.create.topics.enable is enabled on the broker, the
topic will be created with " +
"default settings", topic);
```
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -409,6 +409,9 @@ private boolean sendRecords() {
// RegexRouter) topic creation can not be batched for multiple topics
private void maybeCreateTopic(String topic) {
if (!topicCreation.isTopicCreationRequired(topic)) {
+ log.trace("The topic creation setting is disabled or the topic
name {} is already in the topic cache." +
Review comment:
```suggestion
log.trace("Topic creation by the connector is disabled or the
topic {} was previously created." +
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
