dongjinleekr edited a comment on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-709135091
@vvcephei > it seems like we could improve the test coverage by checking that we get the warning and do not delete the state dir if it's not empty. Totally agree. So, I added two dedicated tests for these cases. See the following test methods: - `StateDirectoryTest#shouldDeleteAppDirWhenCleanUpIfEmpty` - `StateDirectoryTest#shouldNotDeleteAppDirWhenCleanUpIfNotEmpty` I also added an integration test, `StateDirectoryIntegrationTest`. How about this? :smiley: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
