tombentley commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-709457342


   I assumed the scheduler would be using a heap to prioritize scheduled tasks, 
and that wouldn't preserve the order of submitted tasks with the same scheduled 
time. Since `System.currentTimeMillis()` doesn't tick regularly enough I can 
see you could have the two threads end up with the same scheduled time of 
execution (now), but execute in the wrong order. Obviously the FIFO queue 
approach would solve that, at the cost of an extra thread. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to