dongjinleekr commented on pull request #9457: URL: https://github.com/apache/kafka/pull/9457#issuecomment-712677576
Here is some explanation about the last commit. `ProducerRunnable#shutdown` method is never called, and the variable with the same name also not changed from its default value, `false`. Furthermore, this variable does not work as intended; From the non-main thread's context, the modification of this variable's state may not be visible. To make it work as intended, it should be a volatile variable. Since this variable is not used anymore, I thought removing it would be better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org