[GitHub] [kafka] thake commented on a change in pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

[GitBox]

thake commented on a change in pull request #9338:
URL: https://github.com/apache/kafka/pull/9338#discussion_r508392735



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java
##########
@@ -103,6 +104,13 @@ public void init(final StateStoreContext context,
         // register and possibly restore the state from the logs
         maybeMeasureLatency(() -> super.init(context, root), time, 
restoreSensor);
     }
+    protected Serde<K> prepareKeySerde(final Serde<K> keySerde, final Serde<?> 
contextKeySerde, final Serde<?> contextValueSerde) {

Review comment:
       Removed the method completely and added a static import as you proposed 
in your PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org