vamossagar12 commented on a change in pull request #9292:
URL: https://github.com/apache/kafka/pull/9292#discussion_r509005854



##########
File path: 
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##########
@@ -670,12 +675,16 @@ class GroupMetadataManager(brokerId: Int,
                   case unknownKey =>
                     throw new IllegalStateException(s"Unexpected message key 
$unknownKey while loading offsets and group metadata")
                 }
+                messagesRead += 1
+                bytesRead += record.sizeInBytes()
               }
             }
+            batchesRead += 1
             currOffset = batch.nextOffset
           }
         }
 
+        info(s"Number of messages/bytes/batches read: 
$messagesRead/$bytesRead/$batchesRead for partition $topicPartition")

Review comment:
       So, you are saying we add up all items like messages/bytes/batches read 
across all partitions and print them for the total number of partitions? 
   And what you are saying is true, if we have a lot of partitions, then logs 
can be flooded with just these lines... 
   The only thought there is, sometimes it might be useful debugging 
information.. So, instead of info, if we print it at a debug level?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to