hachikuji commented on a change in pull request #9476:
URL: https://github.com/apache/kafka/pull/9476#discussion_r510488902
##########
File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java
##########
@@ -278,13 +265,13 @@ public void
testEndQuorumStartsNewElectionAfterBackoffIfReceivedFromVotedCandida
.withVotedCandidate(epoch, otherNodeId)
Review comment:
The pattern I had in mind was a little different. I was thinking
something like this:
```java
int localId = 0;
int otherNodeId = 1;
int epoch = 2;
Set<Integer> voters = Utils.mkSet(localId, otherNodeId);
RaftClientTestContext context = new
RaftClientTestContext.Builder(localId, voters)
.withVotedCandidate(epoch, otherNodeId)
.build()
```
Then we don't have the awkwardness of the partial reliance on the static
`LOCAL_ID`. I like this better because the ids have to be explicitly declared
in each test case, which makes it easier to follow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
