kkonstantine commented on a change in pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#discussion_r510631763
##########
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##########
@@ -483,6 +483,7 @@ public void logUnused() {
resolvedOriginals.putAll(result.data());
}
}
+ providers.values().forEach(x -> Utils.closeQuietly(x, "config
provider"));
Review comment:
Good observations @jherico . I believe the latter approach, of closing
all the instantiated providers if an exception occurs in both cases, would be
the most straightforward fix.
If you'd be interested in submitting a fix, that would be very welcome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
