hachikuji commented on a change in pull request #9482:
URL: https://github.com/apache/kafka/pull/9482#discussion_r514512213
##########
File path:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java
##########
@@ -113,11 +113,11 @@ protected HistogramSample newSample(long timeMs) {
protected void update(Sample sample, MetricConfig config, double value,
long timeMs) {
final double boundedValue;
if (value > max) {
- log.warn("Received value {} which is greater than max recordable
value {}, will be pinned to the max value",
+ log.debug("Received value {} which is greater than max recordable
value {}, will be pinned to the max value",
Review comment:
The `warn` seemed excessive for a metric update, which could be done
very frequently. I looked over the code and it looks like we don't really use
this outside of tests (and now the code added in this patch). I think the user
should just understand the contract, which is that anything outside of the
specified range gets rounded down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
