anatasiavela commented on a change in pull request #9526:
URL: https://github.com/apache/kafka/pull/9526#discussion_r514636692
##########
File path: core/src/main/scala/kafka/network/RequestChannel.scala
##########
@@ -162,7 +161,7 @@ object RequestChannel extends Logging {
}
}
- trace(s"Processor $processor received request: ${requestDesc(true)}")
+ trace(s"Processor $processor received request:
${RequestConvertToJson.requestDesc(header, loggableRequest, true).toString}")
Review comment:
The macro does check `isTraceEnabled`, and this check is done before the
string is evaluated, so it wouldn't be unnecessarily computed. But I'm also
fine with gating it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
