lbradstreet commented on a change in pull request #9526:
URL: https://github.com/apache/kafka/pull/9526#discussion_r517562348
##########
File path:
generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java
##########
@@ -380,8 +380,9 @@ private void generateVariableLengthTargetToJson(Target
target, Versions versions
target.sourceVariable(), target.sourceVariable())));
}
} else if (target.field().type().isRecords()) {
- headerGenerator.addImport(MessageGenerator.BINARY_NODE_CLASS);
- buffer.printf("%s;%n", target.assignmentStatement("new
BinaryNode(new byte[]{})"));
+ headerGenerator.addImport(MessageGenerator.INT_NODE_CLASS);
+ buffer.printf("%s;%n", target.assignmentStatement(
+ String.format("new IntNode(%s.sizeInBytes())",
target.sourceVariable())));
Review comment:
@dajac if I understand correctly, the current generated JSON does not
print the recordSet either. Is it breaking anything to return the size rather
than an empty array?
```
}
if (_object.recordSet == null) {
_node.set("recordSet", NullNode.instance);
} else {
_node.set("recordSet", new BinaryNode(new byte[]{}));
}
```
That said, implementing a verbose mode (3) where we print out a byte array
seems reasonable if we don't use it in the trace logging path by default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
