wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r517576758
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java
##########
@@ -311,6 +317,22 @@ public void run() {
"Updating global state failed. You can restart KafkaStreams to
recover from this error.",
recoverableException
);
+ } catch (final Exception e) {
+ if (this.streamsUncaughtExceptionHandler == null) {
+ throw e;
+ }
+ if (Thread.getDefaultUncaughtExceptionHandler() != null &&
newHandler) {
+ log.error("Stream's new uncaught exception handler is set as
well as the deprecated old handler." +
+ "The old handler will be ignored as long as a new
handler is set.");
Review comment:
I think it is simpler to check in the Stream thread because we don't in
KafkaStreams if the handlers have been set so we would have to check the stream
thread a global thread so it would be much easier to just check in the thread.
I do agree that it should be bumped down to warn through.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
