rajinisivaram commented on a change in pull request #9560:
URL: https://github.com/apache/kafka/pull/9560#discussion_r520474354
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -331,6 +334,50 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
}
}
+ private[server] def maybeAugmentSslStorePaths(configProps: Properties,
previousConfigProps: Map[String, String]): Unit ={
+ val processedFiles = new mutable.HashSet[String]
+ reconfigurables
+ .filter(reconfigurable =>
ReloadableFileConfigs.exists(reconfigurable.reconfigurableConfigs.contains))
+ .foreach({
+ case reconfigurable: ListenerReconfigurable =>
+ ReloadableFileConfigs.foreach(configName => {
+ val prefixedName = reconfigurable.listenerName.configPrefix +
configName
+ if (!processedFiles.contains(prefixedName) &&
configProps.containsKey(prefixedName) &&
Review comment:
I think the current logic seems reasonable since you can have an update
with no changes where we just want to reload the key/trust stores. In that case
`configProps` would match `previousConfigProps`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
