ableegoldman commented on a change in pull request #9489:
URL: https://github.com/apache/kafka/pull/9489#discussion_r522591013



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -703,6 +703,16 @@ void runOnce() {
             // we record the ratio out of the while loop so that the 
accumulated latency spans over
             // multiple iterations with reasonably large max.num.records and 
hence is less vulnerable to outliers
             taskManager.recordTaskProcessRatio(totalProcessLatency, now);
+
+            // Only log this at INFO when we actually processed some records 
to avoid flooding INFO-level logs when
+            // there are no records on the input topics
+            if (totalProcessed > 0) {
+                log.info("Processed {} records for tasks {}, polling for more 
records now",

Review comment:
       Yeah good call. I promoted one of the debug logs you added earlier to 
log the number of records polled at INFO. I think this should be reasonable but 
we can always demote it again if it's still showing up too frequently




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to