abbccdda commented on a change in pull request #9569:
URL: https://github.com/apache/kafka/pull/9569#discussion_r523264487



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##########
@@ -713,6 +715,8 @@ public void sendOffsetsToTransaction(Map<TopicPartition, 
OffsetAndMetadata> offs
      *         does not support transactions (i.e. if its version is lower 
than 0.11.0.0)
      * @throws org.apache.kafka.common.errors.AuthorizationException fatal 
error indicating that the configured
      *         transactional.id is not authorized. See the exception for more 
details
+     * @throws org.apache.kafka.common.errors.InvalidProducerEpochException if 
the producer has attempted to produce with an old epoch

Review comment:
       I see your point. As of today, if we throw KafkaException then streams 
thread would die as we wrap it as `StreamsException` which is fatal. It's only 
gonna work if we throw InvalidEpoch exception directly and let stream catch and 
swallow it. Do you think that would be the correct way?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to