ijuma commented on a change in pull request #9566:
URL: https://github.com/apache/kafka/pull/9566#discussion_r524722302
##########
File path: clients/src/test/java/org/apache/kafka/common/UuidTest.java
##########
@@ -21,50 +21,50 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;
-public class UUIDTest {
+public class UuidTest {
@Test
public void testSignificantBits() {
- UUID id = new UUID(34L, 98L);
+ Uuid id = new Uuid(34L, 98L);
assertEquals(id.getMostSignificantBits(), 34L);
assertEquals(id.getLeastSignificantBits(), 98L);
}
@Test
- public void testUUIDEquality() {
- UUID id1 = new UUID(12L, 13L);
- UUID id2 = new UUID(12L, 13L);
- UUID id3 = new UUID(24L, 38L);
+ public void testUuidEquality() {
Review comment:
Can we add a test that verifies that the `hashCode` is the same for our
`Uuid` and Java's `UUID`? Or do we have that already?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
