[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

[GitBox]

mjsax commented on a change in pull request #9572:
URL: https://github.com/apache/kafka/pull/9572#discussion_r525435452



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -806,6 +803,13 @@ private KafkaStreams(final InternalTopologyBuilder 
internalTopologyBuilder,
         rocksDBMetricsRecordingService = 
maybeCreateRocksDBMetricsRecordingService(clientId, config);
     }
 
+    private void resizeThreadCache(final int numStreamThreads) {
+        final long cacheSizePreThread = totalCacheSize / (numStreamThreads + 
((globalTaskTopology != null) ? 1 : 0));

Review comment:
       Not sure why the `totalCacheSize` check is relevant for avoiding code 
duplication?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org