mjsax commented on a change in pull request #9572:
URL: https://github.com/apache/kafka/pull/9572#discussion_r525562156
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder
internalTopologyBuilder,
rocksDBMetricsRecordingService =
maybeCreateRocksDBMetricsRecordingService(clientId, config);
}
+ private long getCacheSizePerThread(final int numStreamThreads) {
+ return totalCacheSize / (numStreamThreads + ((globalTaskTopology !=
null) ? 1 : 0));
+ }
+
+ private void resizeThreadCache(final int numStreamThreads) {
+ if (numStreamThreads < 0) {
Review comment:
Well, `getCacheSizePerThread` would eventually return zero (with growing
number of threads), what means that every put() into the cache would result in
an immediate eviction. So I don't think we need to do anything for this corner
case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
