ijuma commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r526203586
########## File path: clients/src/test/java/org/apache/kafka/common/network/TransportLayerUtils.java ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.network; + +import org.apache.kafka.common.errors.AuthenticationException; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.nio.channels.FileChannel; +import java.nio.channels.GatheringByteChannel; +import java.nio.channels.SelectionKey; +import java.nio.channels.SocketChannel; +import java.security.Principal; + +public final class TransportLayerUtils { + private TransportLayerUtils() { + } + + /** + * Create a TransportLayer based on GatheringByteChannel. This helper method is used by testing only and noted that + * not all methods of TransportLayer are supported. + * @param channel channel + * @return a TransportLayer + */ + public static TransportLayer toTransportLayer(GatheringByteChannel channel) { Review comment: If we move the casting in `FileRecords` to `TransportLayers`, then it would be isolated in one class. Also, it's safe casting, not unsafe. That may be OK? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
